chore: flatten pom, add licences to jar#1806
Conversation
toddbaert
changed the title
* use flatten-maven-plugin and maven-resources-plugin * in-lines elements from parent * removes test/publish deps from published pom * packages license into jar Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project configuration by ignoring .flattened-pom.xml in .gitignore, marking compile-time dependencies (lombok and spotbugs) as optional, and adding plugins to flatten the deployed POM and bundle the root LICENSE file into published JARs. The review feedback highlights two issues: first, using ${maven.multiModuleProjectDirectory} requires a .mvn directory at the root of the repository to resolve correctly when building from submodules; second, the maven-resources-plugin will execute unnecessarily for the parent POM (which has pom packaging), creating an empty target/classes/META-INF directory, and should be configured to skip execution on the parent.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
toddbaert
force-pushed
the
fix/pom-flattening
branch
from
44878e3 to
13ba8a5
Compare
|
@toddbaert, is there any chance to make a release after this changes? It will be great to make the legal scanning happy. |
4 participants
Published pom hygiene improvements, and fix missing licence in jars:
Fixes: #1784